[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Xen 4.5 development update (September update). Feature freeze slip by two weeks.

>>> On 10.09.14 at 21:26, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
> On 09/10/14 20:05, konrad.wilk@xxxxxxxxxx wrote:
>> *  Introspection of HVM guests (ok)
>>    v6
>>   -  Razvan Cojocaru
> Will post a new series tomorrow. Three out of 5 patches seem to be Acked
> and haven't had any comments in a while (the first three), and I hope to
> be able to do away completely with patch 4/5 (per-domain page fault
> injection) for now, and just use the existing HVMOP_inject_trap
> interface - but this needs a bit more testing to make sure.

To be honest, despite considering patches 1-3 in acceptable shape
for being committed from a purely mechanical standpoint, I'm still
struggling with general reservations towards them: The whole series
continues to be very focused on special purpose behavior you want
for your product; recent comments from George emphasize that.

As I said before, it would be helpful if you adjusted your thinking to
take general usability of added functionality at least in mind, and if
you made absolutely certain that code changes you do have no
adverse effect on other users. This includes you not rushing out
updates to your series which then you need to supersede within
hours due to oversights or further adjustments. Take your time to
think through as many possibilities as you can (namely including
scenarios that your product does _not_ care about, but others
may), at once taking a certain level of burden off those
subsequently reviewing your patches.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.