[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4] Fix interrupt latency of HVM PCI passthrough devices.

>>> On 10.09.14 at 22:26, <konrad@xxxxxxxxxx> wrote:
>  2). The assert:
>         ASSERT(list_empty(&per_cpu(dpci_list, cpu)));
>      Other code in the hypervisor has 'ASSERT( list_empty..') but the
>      syntax in the io.c file is to have no spaces in the ASSERT.
>      If you would like it to be the same - ASSERT( x ), I can prepare
>      a cleanup patch to fix that.

If you want to invest time into things like this, just go ahead. But
based on what you write above I'm not sure which direction you
want to change things: ASSERT(x) is the correct form, since
ASSERT is not a language keyword and also not a close equivalent
(like for_each_cpu might be considered for example).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.