[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V4 01/15] move x86 EFI boot code to common/efi

>>> On 10.09.14 at 02:51, <roy.franz@xxxxxxxxxx> wrote:
> --- /dev/null
> +++ b/xen/arch/x86/efi/boot.c
> @@ -0,0 +1 @@
> +../../../common/efi/boot.c
> \ No newline at end of file

That's certainly not how I envisioned it - I rather expected the
symlink to be created at build time. That's in any event the more
portable solution (for example I tend to keep source trees on
Windows machines for reference, and I don't think symlinks get
properly expressed there when e.g. extracted from a tarball -
may depend on the tool used of course).

Just create it together with the include/asm one.

And then, as said before, I don't think relocating just boot.c is
going to be sufficient, in which case it would seem more consistent
to move all relevant files in one go.

> diff --git a/xen/arch/x86/efi/efi.h b/xen/include/asm-x86/efi.h
> similarity index 100%
> rename from xen/arch/x86/efi/efi.h
> rename to xen/include/asm-x86/efi.h

This adjustment (and the related ones) seems unnecessary. The
header is strictly local to xen/arch/x86/efi/ (and should remain
unexposed after the move, but might of course be moved along
with the other files).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.