Re: [Xen-devel] [PATCH V4 12/15] Add efi_arch_use_config_file() function to control use of config file

[Roy Franz <roy.franz@xxxxxxxxxx>]

On Fri, Sep 12, 2014 at 12:15 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:

>>> On 12.09.14 at 01:54, <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> On Thu, 11 Sep 2014, Jan Beulich wrote:
>> >>> On 10.09.14 at 02:52, <roy.franz@xxxxxxxxxx> wrote:
>> > -Â Â cols = rows = depth = 0;
>> > -Â Â if ( !base_video )
>> > -Â Â {
>> > -Â Â Â Â name.cs = get_value(&cfg, section.s, "video");
>> > -Â Â Â Â if ( !name.cs )
>> > -Â Â Â Â Â Â name.cs = get_value(&cfg, "global", "video");
>> > -Â Â Â Â if ( name.cs && !strncmp(name.cs, "gfx-", 4) )
>> > +Â Â Â Â cols = rows = depth = 0;
>> > +Â Â Â Â if ( !base_video )
>> >Â Â Â Â Â {
>> > -Â Â Â Â Â Â cols = simple_strtoul(name.cs + 4, &name.cs, 10);
>> > -Â Â Â Â Â Â if ( *name.cs == 'x' )
>> > -Â Â Â Â Â Â Â Â rows = simple_strtoul(name.cs + 1, &name.cs, 10);
>> > -Â Â Â Â Â Â if ( *name.cs == 'x' )
>> > -Â Â Â Â Â Â Â Â depth = simple_strtoul(name.cs + 1, &name.cs, 10);
>> > -Â Â Â Â Â Â if ( *name.cs )
>> > -Â Â Â Â Â Â Â Â cols = rows = depth = 0;
>> > +Â Â Â Â Â Â name.cs = get_value(&cfg, section.s, "video");
>> > +Â Â Â Â Â Â if ( !name.cs )
>> > +Â Â Â Â Â Â Â Â name.cs = get_value(&cfg, "global", "video");
>> > +Â Â Â Â Â Â if ( name.cs && !strncmp(name.cs, "gfx-", 4) )
>> > +Â Â Â Â Â Â {
>> > +Â Â Â Â Â Â Â Â cols = simple_strtoul(name.cs + 4, &name.cs, 10);
>> > +Â Â Â Â Â Â Â Â if ( *name.cs == 'x' )
>> > +Â Â Â Â Â Â Â Â Â Â rows = simple_strtoul(name.cs + 1, &name.cs, 10);
>> > +Â Â Â Â Â Â Â Â if ( *name.cs == 'x' )
>> > +Â Â Â Â Â Â Â Â Â Â depth = simple_strtoul(name.cs + 1, &name.cs, 10);
>> > +Â Â Â Â Â Â Â Â if ( *name.cs )
>> > +Â Â Â Â Â Â Â Â Â Â cols = rows = depth = 0;
>> > +Â Â Â Â Â Â }
>>
>> So how is this video mode selection being represented then without
>> config file? Don't you need to at least add a command line option for
>> that?
>
> The scenario without config file is the one where Xen is loaded by GRUB.
> Do we actually need to pass a video mode option in that case?
> Wouldn't GRUB take care of changing video mode itself to the value
> specified by the user before booting Xen? Xen can query the current
> video mode afterwards.

Ah, right, that's a good point.

Jan

I think we can leave this to GRUB in this case. ÂIt seems to have the capability to set

video modes use EFI calls so it should be able to take care of this as well as the EFI boot

portion of XEN. ÂOne of the difficulties with arm64 development right now is that most of it is being

done on platforms without video, so any video code is rarely used or tested.Â

Roy

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel