Re: [Xen-devel] [PATCH] Avoid clang prior initialization error when listing MTRR flags

[Marcin Cieslak <saper@xxxxxxxxxx>]

On Mon, 15 Sep 2014, Jan Beulich wrote:

> > > > On 13.09.14 at 18:57, <saper@xxxxxxxxxx> wrote:
> > generic.c:97:32: error: initializer overrides prior initialization of this
[...]
> Apart from the description above being excessive (quoting just one
> of the error messages would completely suffice), I'm NAKing this
> because it was intentionally coded the way it is. What I would
> suggest instead is to enforce -Wno-initializer-overrides.
Thanks for reviewing this! I will try to improve in the future.
> And as a side note - this change is more than just elimination of
> the compiler warning.
Good question how to avoid it. Do you prefer to spell out all
cases or to use -Wno-initializer-overrides? Which initializer
should compilers use?

//Marcin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel