Re: [Xen-devel] [PATCH V2 3/3] xen: eliminate scalability issues from initial mapping setup

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.09.14 at 16:07, <david.vrabel@xxxxxxxxxx> wrote:
> On 17/09/14 05:12, Juergen Gross wrote:
>> +static void __init xen_cleanmfnmap(unsigned long vaddr)
>> +{
>> +    unsigned long va = vaddr & PMD_MASK;
>> +    unsigned long pa;
>> +    pgd_t *pgd = pgd_offset_k(va);
>> +    pud_t *pud_page = pud_offset(pgd, 0);
>> +    pud_t *pud;
>> +    pmd_t *pmd;
>> +    pte_t *pte;
>> +    unsigned int i;
>> +
>> +    set_pgd(pgd, __pgd(0));
>> +    do {
>> +            pud = pud_page + pud_index(va);
>> +            if (pud_none(*pud)) {
>> +                    va += PUD_SIZE;
>> +            } else if (pud_large(*pud)) {
>> +                    pa = pud_val(*pud) & PHYSICAL_PAGE_MASK;
>> +                    xen_free_ro_pages(pa, PUD_SIZE);
>> +                    va += PUD_SIZE;
> 
> Are you missing a ClearPagePinned(..) here?

No, this is a 1Gb data page, not a page table one.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel