[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 05/16] tools part of add vmware_port to xl.cfg

On 09/15/14 06:03, George Dunlap wrote:
> On Mon, Sep 8, 2014 at 2:15 PM, Don Slutz <dslutz@xxxxxxxxxxx> wrote:
>> If non-zero then
>>    enable a limited support of VMware's hyper-call.
>> VMware's hyper-call is also known as VMware Backdoor I/O Port.
>> Signed-off-by: Don Slutz <dslutz@xxxxxxxxxxx>
> Overall this looks fine, but is there any reason not to merge this with 03/16?

The reason I have is that v3 03/16 only contains new files. 2 from VMware
and 1 to allow use of the VMware files.  I added
xen/arch/x86/hvm/vmware/includeCheck.h at the request of Konrad Wilk.

This patch has many style issues and white space issues.  So I want it as
a separate patch so as to be clear on what files do not meet the coding 
And why and where they came from.

Hope this helps.
     -Don Slutz
Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.