Re: [Xen-devel] [RFC PATCH] xen/arm: GICv3 support for domU

[Vijay Kilari <vijay.kilari@xxxxxxxxx>]

On Mon, Sep 22, 2014 at 6:14 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> Hello Vijay,
>
> On 09/22/2014 12:53 PM, Vijay Kilari wrote:
>> On Mon, Sep 15, 2014 at 8:43 PM, Vijay Kilari <vijay.kilari@xxxxxxxxx> wrote:
>>> Hi Julien,
>>>
>>> On Sat, Sep 13, 2014 at 3:39 AM, Julien Grall <julien.grall@xxxxxxxxxx> 
>>> wrote:
>>>> Hi Vijay,
>>>>
>>>> On 20/08/14 03:09, vijay.kilari@xxxxxxxxx wrote:
>>>>>
>>>>> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
>>>>>
>>>>> Update libxl tool for arm64 to generate GICv3 device
>>>>> tree node for domU.
>>>>>
>>>>> This patch is only for verifying DomU boot on hardware
>>>>> with GICv3 support and hardcodes GICv3 node information
>>>>> for DomU. Clean implementation is required using
>>>>> domctl
>>>>
>>>>
>>>> Thank you for this patch. Do you plan to send a clean implementation soon?
>>>
>>> I plan to implemented generic gicv2/gicv3 dt node
>>> based on your patch "xen/dts: Add hypercalls to retrieve device node
>>> information"
>>> to read gic device compatibility.
>>
>> Your patch "xen/dts: Add hypercalls to retrieve device node information"
>> always relies on full node patch to read device node information.
>>
>> But in some cases, like GIC we don't have full patch. Here we need
>> to fetch node information like compatibility and other properties like 
>> number of
>> re-distributor regions, re-distributor offset etc., from node name.
>>
>> So new set of hypercalls which take node name instead of path is required.
>
> I guess when you said "patch", you meant "path", right?

Yes path

>
> Why do you need to get those information? You should define yourself the
> regions of the GICv3 in the guest layout and not relying on the host DT.

In make_intc_node() in llibxl_arm.c the compatibility and mmio regions are
hardcoded to GICv2. So to make it GICv3 I think of two options

1) Generate GIC node for domU that host DT supports.
    With this approach I thought of using the hypercalls that you have created.
2) Parse domU config file and generate GIC accordingly?

Regards
Vijay

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel