Re: [Xen-devel] [PATCH for-4.5 v3 2/3] xen: add helpers for PDX mask initialisation calculations

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 09/22/2014 04:42 PM, Ian Campbell wrote:
> On Thu, 2014-09-18 at 12:16 -0700, Julien Grall wrote:
>>> +u64 pdx_region_mask(u64 base, u64 len)
>>
>> fill_mask is marked as __init. For consistency, those 2 functions should 
>> be marked too.
> 
> Just resending that one patch:
> 
> --------------------------
> 
> From 6a554cc2d7dc076eb4f6ed6f922fa95eea113fa5 Mon Sep 17 00:00:00 2001
> From: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Date: Tue, 16 Sep 2014 21:01:41 +0100
> Subject: [PATCH] xen: add helpers for PDX mask initialisation calculations
> 
> I wanted to make fill_mask a public function so I could use it on ARM, but it
> was actually easier to think of a (semi) reasonable public name for the users
> of it, so that is what I have done.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel