Re: [Xen-devel] [PATCH 20/46] tools/hotplug: use XEN_SCRIPT_DIR instead of hardcoded path

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-09-22 at 15:00 +0200, Olaf Hering wrote:
> Helper scripts get installed into XEN_SCRIPT_DIR, but initscripts,
> helper scripts and udev rules still refer to the hardcoded location
> /etc/xen/scripts/. Update scripts, rules and Makefile to refer to
> @XEN_SCRIPT_DIR@ instead.
> Update configure.ac to substitute the path in files using XEN_SCRIPT_DIR.
> Remove XEN_SCRIPT_DIR from StdGNU.mk and SunOS.mk, its already in
> Paths.mk.

> Note: In SunOS.mk it refered to PRIVATE_PREFIX, which was
> likely a typo introduced by 9f6d07bac9f14aaa8bafe38b4a217e61a3a57842
> ("tools: get rid of hardcoded config dirs")

Are you sure? It seems like a plausible place for some OS to want it.

Not sure how relevant that is though, SunOS.mk won't be used much these
days, and I'm not 100% sure it isn't already broken... If it becomes an
issue we can add --with-scriptdir

> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> tools/configure.ac                                       |  6 ++++++

Please do mention the need to rerun autogen.sh in the commit log for the
benefit of the committer, who might otherwise forget...


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel