Re: [Xen-devel] [PATCH V5 07/15] Move x86 specific disk probing code

[Roy Franz <roy.franz@xxxxxxxxxx>]

On Mon, Sep 22, 2014 at 5:20 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 19.09.14 at 00:49, <roy.franz@xxxxxxxxxx> wrote:
>> Move x86 specific disk (EDD) probing to arch specific file.  This code is x86
>> only and relates to legacy BIOS handling of disk drives.
>>
>> Signed-off-by: Roy Franz <roy.franz@xxxxxxxxxx>
>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> as soon as ...
>
>> +static void __init efi_arch_edd(void)
>> +{
>> +    static EFI_GUID __initdata bio_guid = BLOCK_IO_PROTOCOL;
>> +    static EFI_GUID __initdata devp_guid = DEVICE_PATH_PROTOCOL;
>> +    EFI_HANDLE *handles = NULL;
>> +    int i;
>
> ... this becomes "unsigned int". Didn't you say you'd go through the
> whole series and correct these?
>
> Jan
>
My review all comment was regarding the blank line between variable
definitions and statements in functions. (looks like I missed one of
those too.)

I will fix this and review types of all local variables created in the
arch specific functions.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel