Re: [Xen-devel] [PATCH 44/46] Include Paths.mk in toplevel Makefile to fix uninstall

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-09-22 at 15:00 +0200, Olaf Hering wrote:
> make uninstall references various variable paths.

> If they are not set it may wipe /*.

Urk!

I think the uninstall run may need some sort of sanity check to ensure
you have run configure then.

tools/Rules.mk has:

        ifeq (,$(findstring clean,$(MAKECMDGOALS)))
        $(XEN_ROOT)/config/Tools.mk:
                $(error You have to run ./configure before building or 
installing the tools)
        endif

which could perhaps be adapted. Alternatively splitting uninstall into
uninstall-$subsystem and having the non-Xen subsystems start with a
check that PREFIX (or some suitable variable) is non-empty?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel