[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V5 06/15] Add efi_arch_handle_cmdline() for processing commandline

>>> On 23.09.14 at 03:40, <roy.franz@xxxxxxxxxx> wrote:
> On Mon, Sep 22, 2014 at 5:17 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>>> On 19.09.14 at 00:49, <roy.franz@xxxxxxxxxx> wrote:
>>> @@ -256,7 +257,8 @@ static void __init PrintErrMesg(const CHAR16 *mesg, 
>>> EFI_STATUS ErrCode)
>>>  }
>>>  static unsigned int __init get_argv(unsigned int argc, CHAR16 **argv,
>>> -                                    CHAR16 *cmdline, UINTN cmdsize)
>>> +                                    CHAR16 *cmdline, UINTN cmdsize,
>>> +                                    CHAR16 **options)
>> I think this would better be named "dom0_options" or "dom0_opts" or
>> some such (also in the caller).
> I think xen_options would be better, or else I'm really confused :)
> This string is combined with the Xen options from the
> config file into mbi.cmdline. Dom0 arguments come from the "kernel"
> line in the configuration tile.

Indeed - I mixed things up: This is the first "--" separator, the Dom0
options come after the second. In which case staying with just
"options" is quite fine.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.