Re: [Xen-devel] [PATCH 32/46] Add configure --with-linux-backend-modules="mod1 mod2"

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-09-23 at 14:41 +0200, Olaf Hering wrote:
> On Tue, Sep 23, Ian Campbell wrote:
> 
> > On Mon, 2014-09-22 at 15:00 +0200, Olaf Hering wrote:
> > > +LINUX_BACKEND_MODULES="`eval echo $LINUX_BACKEND_MODULES`"
> > 
> > Why does this need to be laundered via eval? There's no sensible way a
> > user could want to pass in \$thing and expect it to expand to something
> > useful, is there?
> 
> I decided to use a multiline assignment to make futher patches to the
> content easier to read. If the variable is expanded it will appear as is
> in the Makefile, resulting in syntax errors.

Ah, so you are just trying to fold the \n, ok.

> Maybe a single echo would work as well. 

I would expect so.

It's possible that the application of some more "s (e..g in the
initscript itself) might also work.

> Will check if this can be improved. But I fear there is not much that
> can be done to achieve "\$thing".

Oh, we don't actually want that, I just thought that was what you were
trying to do for some reason.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel