Re: [Xen-devel] [PATCH v11 for-xen-4.5 15/20] x86/VPMU: Add support for PMU register handling on PV guests

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

>  static void core2_vpmu_load(struct vcpu *v)
> @@ -447,7 +461,6 @@ static int core2_vpmu_msr_common_check(u32 msr_index, int 
> *type, int *index)
>  static int core2_vpmu_do_wrmsr(unsigned int msr, uint64_t msr_content,
>                                 uint64_t supported)
>  {
> -    u64 global_ctrl;
>      int i, tmp;
>      int type = -1, index = -1;
>      struct vcpu *v = current;
> @@ -492,6 +505,7 @@ static int core2_vpmu_do_wrmsr(unsigned int msr, uint64_t 
> msr_content,
>      {
>      case MSR_CORE_PERF_GLOBAL_OVF_CTRL:
>          core2_vpmu_cxt->global_status &= ~msr_content;
> +        wrmsrl(MSR_CORE_PERF_GLOBAL_OVF_CTRL, msr_content);

The original code does the write in core2_vpmu_do_interrupt with a bunch of 
filtering.
Is there a particular reason we don't want to do that?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel