Re: [Xen-devel] [RFC PATCH] xen/arm: remove check for generic timer support for arm64

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-09-18 at 17:43 +0530, vijay.kilari@xxxxxxxxx wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> 
> Information about support for generic support is available in
> IDR_PFR1 register in ARMv7. Where as this information is not
> available in ARMv8 that supports only aarch64 bit mode.
> ARMv8 being always supports generic timer, this check is not
> required.
> 
> For platforms that support only aarch64 mode, IDR_PFR1 is
> not implemented

I think this answers my question on "check on domain type against
hardware support"...


> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>

But this patch is itself OK:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
>  xen/include/asm-arm/cpufeature.h |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/xen/include/asm-arm/cpufeature.h 
> b/xen/include/asm-arm/cpufeature.h
> index aec9173..7a6d3de 100644
> --- a/xen/include/asm-arm/cpufeature.h
> +++ b/xen/include/asm-arm/cpufeature.h
> @@ -27,7 +27,11 @@
>  #define cpu_has_jazelle   (boot_cpu_feature32(jazelle) >= 0)
>  #define cpu_has_thumbee   (boot_cpu_feature32(thumbee) == 1)
>  
> +#ifdef CONFIG_ARM_32
>  #define cpu_has_gentimer  (boot_cpu_feature32(gentimer) == 1)
> +#else
> +#define cpu_has_gentimer  (1)
> +#endif
>  #define cpu_has_security  (boot_cpu_feature32(security) > 0)
>  
>  #endif



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel