Re: [Xen-devel] [PATCH v4 3/3] enable QEMU for ARM builds

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-09-23 at 17:41 +0100, Ian Campbell wrote:
> On Tue, 2014-09-23 at 17:35 +0100, Stefano Stabellini wrote:
> > On Tue, 23 Sep 2014, Ian Campbell wrote:
> > > On Tue, 2014-09-23 at 17:29 +0100, Stefano Stabellini wrote:
> > > > On Tue, 23 Sep 2014, Ian Campbell wrote:
> > > > > On Tue, 2014-09-23 at 15:56 +0100, Stefano Stabellini wrote:
> > > > > > Does the following fix the issue for you?
> > > > > 
> > > > > I needed some new build-deps (pixman) but then it appeared to, yes.
> > > > > 
> > > > > I'm in favour of moving the --cpu out from under the
> > > > > IOEMU_CONFIGURE_CROSS and into the normal configure rune. It should be
> > > > > harmless for native builds and will ensure that cross builds don't
> > > > > regress again. Maybe that is more complex with the qemu-trad side of
> > > > > things?
> > > > 
> > > > I don't think so: qemu-trad is not used on arm or arm64.
> > > > I think that the x86_32 tools build on x86_64 still has some other
> > > > issues but this should be an improvement.
> > > 
> > > I wasn't sure if qemu-trad even had --cpu, seem it does?
> > > 
> > > > ---
> > > > Fix QEMU cross-compile build
> > > > 
> > > > Introduce the per-arch IOEMU_CPU_ARCH variable.
> > > > Always pass --configure=IOEMU_CPU_ARCH to QEMU's configure script.
> > > > 
> > > > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > > 
> > > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > > 
> > > Although the comments in config/*.mk are a bit redundant (would you like
> > > me to drop as I apply?)
> > 
> > Sure.
> 
> ok, will look tomorrow.
> 
> >  Also please test as my cross-compiling environments are limited.
> 
> My standard precommit builds are native apart from arm64 which is cross.
> I reckon that will do.

These all passed, so I've pushed. Thanks!



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel