Re: [Xen-devel] [OSSTEST PATCH RFC v1 08/12] ts-xen-install: install Xen with XSM support if requested

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-09-24 at 14:21 +0100, Wei Liu wrote:
> On Wed, Sep 24, 2014 at 02:16:45PM +0100, Wei Liu wrote:
> > On Wed, Sep 24, 2014 at 11:41:34AM +0100, Ian Campbell wrote:
> > > On Mon, 2014-09-22 at 15:11 +0100, Wei Liu wrote:
> > > > +                    'find /boot -name \'xenpolicy-*\' -exec basename 
> > > > {} \;');
> > > 
> > > (stray tabs)
> > > 
> > > > +       # there should only be one xenpolicy file for a clean install
> > > > +       my $c = () = $flaskpolicy =~ /xenpolicy/g;
> > > 
> > > I'm curious, what does that () do?
> > > 
> > 
> > This is called "empty parentheses" idiom. It's used to force list
> > context on an expression, and yet return a scalar: the count of items in
> > that list.
> > 
> > http://www.perlmonks.org/?node_id=527973

Neat!

> > > Does the grub patch thing work on arm (where I'm not sure if grub will
> > > be there or not)?
> > > 
> > 
> > No. AIUI arm doesn't use grub, does it?
> > 
> 
> That patch only applies to the grub carried in the particular version of
> Wheezy we use in OSSTest. So when grub eventually comes to arm, it won't
> work. But I'm kind of hoping when grub comes to arm we've already
> upstreamed this patch and thus can drop it in OSSTest.

My concern was that the test would work today on an ARM system without
grub (i.e. it isn't trying to patch a non-existent file etc).

When we come to support ARM systems with grub via osstest then there
will certainly be updates required, this will probably be the least of
them ;-)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel