Re: [Xen-devel] [PATCH for-4.5 v8 05/19] xen: Relocate set_access_required domctl into common

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Wed, Sep 24, 2014 at 4:18 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:

Hi Tamas,

On 09/23/2014 02:14 PM, Tamas K Lengyel wrote:
> @@ -1116,6 +1117,20 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
>      }
>      break;
>
> +    case XEN_DOMCTL_set_access_required:
> +    {
> +        struct p2m_domain* p2m;
> +
> +        ret = -EPERM;
> +        if ( current->domain == d )
> +            break;
> +
> +        ret = 0;
> +        p2m = p2m_get_hostp2m(d);
> +        p2m->access_required = op->u.access_required.access_required;
> +    }
> +    break;
> +

IHMO this DOMCTL should only exist when mem access is supported/compiled
for the specific architecture. (i.e when HAS_MEM_ACCESS is defined).

Regards,

--
Julien Grall

Ack, it certainly wouldn't hurt although technically right now it is supported on both architectures that Xen supports. I can see it being beneficial going forward in case another arch is added.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel