[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.5 v8 19/19] tools/tests: Enable xen-access on ARM

On Tue, 2014-09-23 at 15:14 +0200, Tamas K Lengyel wrote:
> Define the ARM specific test_and_set_bit functions and switch
> to use maximum gpfn as the limit to setting permissions. Also,
> move HAS_MEM_ACCESS definition into config.

Please could you mention the removal of the x86 comment about atomicity
here, since the reasoning for its correctness will be of interest to
future code archaeologists.

> -    rc = xc_set_mem_access(xch, domain_id, default_access, 0,
> -                           xenaccess->domain_info->max_pages);
> +    rc = xc_set_mem_access(xch, domain_id, default_access, START_PFN,
> +                           (xenaccess->max_gpfn - START_PFN) );

So the reason why info->max_pages is no use any more is because ARM
starts at non-zero and has multiple banks?

I suppose that's fair enough.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.