Re: [Xen-devel] [PATCH v2 4/5] xen/x86: Use constant as multiboot protocol identifier

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 24/09/14 18:19, Daniel Kiper wrote:
> Use constant as multiboot protocol identifier instead of plain number.
>
> Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper@xxxxxxxxxx>

Again - should be ahead of functional changes in your series.

> ---
> v2 - suggestions/fixes:
>    - patch split rearrangement
>      (suggested by Andrew Cooper and Jan Beulich).
> ---
>  xen/arch/x86/boot/head.S |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S
> index 79bce3c..7e48833 100644
> --- a/xen/arch/x86/boot/head.S
> +++ b/xen/arch/x86/boot/head.S
> @@ -82,7 +82,7 @@ __start:
>          mov     %ecx,%ss
>  
>          /* Check for Multiboot bootloader */
> -        cmp     $0x2BADB002,%eax
> +        cmp     $MULTIBOOT_BOOTLOADER_MAGIC,%eax
>          jne     not_multiboot
>  
>          /* Set up trampoline segment 64k below EBDA */


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel