[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.5 V6 00/14] arm64 EFI stub



On Wed, Sep 24, 2014 at 1:55 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 24.09.14 at 07:02, <roy.franz@xxxxxxxxxx> wrote:
>> Open feedback:
>> * moving extern declaration of efi_l4_pgtable.  I have left this x86 specific
>>   declaration in the x86 specific efi-boot.h file, as I don't see a clearly
>>   better place to put it.
>
> Since runtime.c (hopefully) doesn't include efi-boot.h, this is certainly
> not a viable option - files defining variables should include the headers
> declaring them.
>
> Jan
>

I'll move it and add a #ifdef

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.