Re: [Xen-devel] [PATCH for-4.5 V7 14/14] Add ARM EFI boot support

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.09.14 at 19:05, <roy.franz@xxxxxxxxxx> wrote:
> On Thu, Sep 25, 2014 at 3:49 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>>> On 25.09.14 at 03:42, <roy.franz@xxxxxxxxxx> wrote:
>>> --- a/xen/common/efi/runtime.c
>>> +++ b/xen/common/efi/runtime.c
>>> @@ -4,17 +4,22 @@
>>>  #include <xen/guest_access.h>
>>>  #include <xen/irq.h>
>>>  #include <xen/time.h>
>>> -#include <asm/mc146818rtc.h>
>>> +
>>> +extern spinlock_t rtc_lock;
>>
>> No extern declarations in .c files for things being defined in other .c
>> files please.
> 
> OK, I'll have to look at making asm/mc146818rtc.h a common file, or
> moving the extern declaration from that x86 specific include file to a
> common one.
> (or #ifdef CONFIG_X86 this and the spinlock, but that's not nice either.)

Just like you introduced efi-boot.h (which really should have been
just boot.h, but I noticed this only when already having been
through most of the part that I committed yesterday), we'll need
runtime.h anyway sooner or later, and that's where the #include
should get moved imo (even if for now this may end up being the
only content of that file).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel