[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.5 v2] x86/hvm: remove stray ioreq_server.lock lock release from hvm_ioreq_server_init()

>>> On 26.09.14 at 15:27, <vkuznets@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -993,7 +993,6 @@ static int hvm_ioreq_server_init(struct hvm_ioreq_server 
> *s, struct domain *d,
>      hvm_ioreq_server_free_rangesets(s, is_default);
>   fail1:
> -    spin_unlock(&d->arch.hvm_domain.ioreq_server.lock);
>      return rc;
>  }

I'd really like to see the fail1 label gone with this, perhaps at once
renaming the others to "fail_map" and "fail_add". And please also
shorten the title to e.g. "x86/hvm: remove stray lock release from
hvm_ioreq_server_init()" - after all there's only one lock being
released there right now, so this is unambiguous.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.