Re: [Xen-devel] Some oxenstored improvements (v3)

[Dave Scott <Dave.Scott@xxxxxxxxxx>]

Hi,

On 29 Sep 2014, at 15:37, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote:

> On Thu, Sep 25, 2014 at 06:34:53PM +0100, Zheng Li wrote:
>> This is mainly about removing the 1024 fds limitation in the current 
>> oxenstored
>> implementation. We also fixed some bugs and made some perf improvements along
>> the way.
>> 
>> This is v3. The first 6 patches are the same as in v2. For patch 7/8/9, we
>> 
>>  * Add a safe net mechanism for ill-behaved legacy clients
>>  * Make some performance improvement to reduce syslog workload
>>  * Small refactoring on patch 7/8 to accomodate the new changes
> 
> That all looks quite nice but I have no experience with OCaml.
> 
> I fear that this patchset will have wait until an OCaml expert can
> review the code :-(

I’ve just read through the v3 patches and am happy with them. So I’m happy to 
give them an

  Acked-by: David Scott <dave.scott@xxxxxxxxxx>

I think this patch:

[PATCH v3 4/9] oxenstored: catch the error when a connection is already deleted

is a useful bug fix — this might explain why oxenstored has occasionally 
‘disappeared’ in mysterious circumstances. Zheng: could this patch be taken by 
itself? If so I think the release should definitely have it.

The rest of the patches will help scalability a lot but aren’t critical fixes. 
They would (IMHO) increase the quality of the release though.

Cheers,
Dave

>> 
>> Cheers,
>> Zheng
>> 
>> 
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxx
>> http://lists.xen.org/xen-devel
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel