Re: [Xen-devel] [PATCH for-4.5] EFI: Ignore EFI commandline, skip console setup when booted from GRUB

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.11.14 at 07:13, <roy.franz@xxxxxxxxxx> wrote:
> This patch implements what I understand to be the desired behavior when 
> booting
> an EFI Xen image via GRUB based on the thread last week.  The EFI command 
> line
> is not used, and the Xen commandline comes via the multiboot protocol (and
> in the ARM case the multiboot FDT bindings).  This brings the x86 and arm64
> GRUB EFI boot cases into alignment in not using the EFI commandline.

Right, but ...

> The current state of the arm64 code takes the Xen commandline from the FDT,
> but still looks in the EFI commandline for EFI boot specific options.  If
> unexpected options are passed in the EFI commandline, it will generate
> "unrecognized option" ouput for all unexpected options.

... why is this?

> +    if ( use_cfg_file )
>      {
>          EFI_FILE_HANDLE dir_handle;
> +        size = 0;

Coding style (missing blank line between declaration(s) and
statement(s). Plus - did you check whether some of the so far
function wide variables (e.g. gop) could be moved into this more
narrow scope?

>              }
>          }
>      }
> -
>      efi_arch_edd();
>  
>      /* XXX Collect EDID info. */

Please don't.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel