Re: [Xen-devel] [v2][PATCH] tools/hvmloader: link errno.h from xen internal

["Chen, Tiejun" <tiejun.chen@xxxxxxxxx>]

On 2014/11/3 17:43, Jan Beulich wrote:
> > > > On 03.11.14 at 10:00, <tiejun.chen@xxxxxxxxx> wrote:
> > --- a/tools/firmware/hvmloader/Makefile
> > +++ b/tools/firmware/hvmloader/Makefile
> > @@ -84,9 +84,12 @@ ROMS += $(SEABIOS_ROM)
> >   endif
> >
> >   .PHONY: all
> > -all: subdirs-all
> > +all: subdirs-all .dir
> Considering uses going forward, I think subdirs-all should depend on
> .dir (which is being misnamed anyway, presumably due to blindly
> taking what is in tools/include/Makefile, where a directory _is_ being
> created). Considering that it's an individual file, the file name would
You're right.

> seem quite right to be used as dependency here.
So what about this?

.PHONY: all
all: subdirs-all errno
    $(MAKE) hvmloader

errno:
    ln -sf $(XEN_ROOT)/xen/include/xen/errno.h .

Thanks
Tiejun

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel