Re: [Xen-devel] [PATCH 06/10] xen/arm: handle GICH register changes for hip04-d01 platform

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Frediano,

On 11/03/2014 10:11 AM, Frediano Ziglio wrote:
>  static void gicv2_irq_enable(struct irq_desc *desc)
> @@ -731,6 +733,8 @@ static int __init gicv2_init(struct dt_device_node *node, 
> const void *data)
>      {
>          nr_gic_cpu_if = 16;
>          gic_cpu_mask = 0xffff;
> +        gich_apr = HIP04_GICH_APR;
> +        gich_lr = HIP04_GICH_LR;
>      }
>  
>      res = dt_device_get_address(node, 0, &gicv2.dbase, NULL);
> diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h
> index 3d2b3db..804bf24 100644
> --- a/xen/include/asm-arm/gic.h
> +++ b/xen/include/asm-arm/gic.h
> @@ -88,6 +88,8 @@
>  #define GICH_ELSR1      (0x34)
>  #define GICH_APR        (0xF0)
>  #define GICH_LR         (0x100)
> +#define HIP04_GICH_APR  (0x70)
> +#define HIP04_GICH_LR   (0x80)

Please move thoses define in gic-v2.c. The header gic.h should only
contains value that needs to be shared with the vgic and/or the other
GIC drivers.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel