[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 for-4.5] xen: Bump Xen interface for Xen-4.5



>>> On 04.11.14 at 12:50, <andrew.cooper3@xxxxxxxxxx> wrote:
> c/s fce5281c "x86/mem_access: Deprecate the HVM mem_access ops" removes the
> structures associated with xen_hvm_{get,set}_mem_access from the Xen public
> API.
> 
> While these were toolstack hypercalls and documented as liable to change in
> the future, it causes build issues for certain tools (valgrind, strace).
> 
> As HVM ops have no specific interface version, the main Xen interface 
> version
> needs to be bumped to compensate.

Content-wise I don't really object to this patch, but I view it as
merely cosmetic rather than fixing anything: Tool stack interfaces
are declared to be volatile just because we want to avoid exactly
this need for bumping versions or anything when altering or
dropping them. If there are out of tree consumers of them, it is
their responsibility to keep up with our changes (or have their
own clones of the canonical headers).

Also we didn't bother incrementing the version just because of a
release on earlier occasions: 3.3 and 3.4 as well as 4.0 and 4.1
shared interface versions, yet especially in the case of 4.1 I'm
pretty certain even without explicitly checking that there were
tool stack interface changes.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.