Re: [Xen-devel] [PATCH v3 4/8] xen/arm: Add support for DTBs with strange names of Hip04 GICv2

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Zoltan,

On 06/11/2014 09:46, Zoltan Kiss wrote:
> On 05/11/14 14:52, Stefano Stabellini wrote:
> > On Wed, 5 Nov 2014, Julien Grall wrote:
> > > Hi Frediano,
> > >
> > > On 11/05/2014 09:41 AM, Frediano Ziglio wrote:
> > > > This name can appear in some Linux kernel repos. Not very fortunate,
> > > > but to avoid others spending an hour to spot that few characters
> > > > difference it worth to work around it.
> > > Linux upstream is using "hisilicon,hip04-intc" to detect the hisilicon
> > > interrupt controller. So it's not a workaround.
> > >
> > > Which kernel is using the "*,hip04-gic"?
> > Good question, but what really matters is the string that u-boot (or any
> > other firmware/bootloader) is going to use, right? So, which one is it?
> We are using the DTB from the kernel source, even when loading a bare
> metal kernel. I've looked around, the *gic version seems to exist only
> in internal repos, as far as I can see. Including the one Frediano
> started to use for porting. Therefore, I don't insist to keep both, but
> as I mentioned in the commit message, it would still provide some
> benefit, and given that it's just a 3 line change which just extend a
> few listings, I think we should keep it.
In general, Xen should respect the binding that has been agreed by the 
device tree team. Anything different should not be upstream, hence it's 
for only internal purpose.
> Of course with a different commit message, which clears that this is the
> official name of it.
If it happens that both compatible are upstream. I would prefer that you 
define the *-intc one in the patch #3 and *-gic in #4.
It's more logical than defining first the non-official and then the 
official.
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel