Re: [Xen-devel] [PATCH for-4.5] xl: correct test condition on libxl_domain_info

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Nov 12, 2014 at 10:22:07AM -0500, Konrad Rzeszutek Wilk wrote:
> On Wed, Nov 12, 2014 at 11:10:52AM +0000, Ian Campbell wrote:
> > CCing the folks who signed-of-by is on the original patch
> > 
> > On Wed, 2014-11-12 at 11:05 +0000, Wei Liu wrote:
> > > The `if' statement considered return value 0 from libxl_domain_info an
> > > error, while 0 actually means success.
> > > 
> > > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > 
> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > 
> > > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > > ---
> > > This is a bug fix for PSR feature. This feature was added recently and 
> > > it's
> > > not an regression. However, it would be good to have it working correctly
> > > since the beginning, and the fix is straightforward, which should be of
> > > very low risk.
> > 
> > Ack.
> 
> I concur and I think it should go in Xen 4.5, but I would like their
> input first.
> 

Dude, you're so cautious! ;-)

> > 
> > > ---
> > >  tools/libxl/xl_cmdimpl.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> > > index 3c9f146..9afef3f 100644
> > > --- a/tools/libxl/xl_cmdimpl.c
> > > +++ b/tools/libxl/xl_cmdimpl.c
> > > @@ -7908,7 +7908,7 @@ static int psr_cmt_show_cache_occupancy(uint32_t 
> > > domid)
> > >      /* Each domain */
> > >      if (domid != INVALID_DOMID) {
> > >          libxl_dominfo dominfo;
> > > -        if (!libxl_domain_info(ctx, &dominfo, domid)) {
> > > +        if (libxl_domain_info(ctx, &dominfo, domid)) {
> > >              fprintf(stderr, "Failed to get domain info for %d\n", domid);
> > >              return -1;
> > >          }
> > 
> > 
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxx
> > http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel