Re: [Xen-devel] [PATCH] libxc: Turn on the pdpe1gb cpuid flag by default

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.11.14 at 06:31, <liang.z.li@xxxxxxxxx> wrote:

Apart from the subject being kind of wrong (you're not turning it on
by default, but only expose it if the hardware supports it), ...

> --- a/tools/libxc/xc_cpuid_x86.c
> +++ b/tools/libxc/xc_cpuid_x86.c
> @@ -192,6 +192,7 @@ static void intel_xc_cpuid_policy(
>                      bitmaskof(X86_FEATURE_ABM));
>          regs[3] &= (bitmaskof(X86_FEATURE_NX) |
>                      bitmaskof(X86_FEATURE_LM) |
> +                    bitmaskof(X86_FEATURE_PAGE1GB) |
>                      bitmaskof(X86_FEATURE_SYSCALL) |
>                      bitmaskof(X86_FEATURE_RDTSCP));
>          break;

... this is incomplete: The AMD function would seem to need the
same change, and the !PAE special casing in xc_cpuid_hvm_policy()
should imo disable the flag.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel