Re: [Xen-devel] [PATCH for-4.5 1/2] libxl: continue when encounter ERROR_JSON_CONFIG_EMPTY

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Nov 14, 2014 at 10:55:35AM +0000, Ian Campbell wrote:
> On Fri, 2014-11-14 at 10:52 +0000, Ian Campbell wrote:
> > On Wed, 2014-11-12 at 17:04 +0000, Wei Liu wrote:
> > > Continue when libxl_retrieve_domain_configuration encounters
> > > ERROR_JSON_CONFIG_EMPTY, as caller might be interested in the partial
> > > configuration pulled from xenstore.  In this case
> > > ERROR_JSON_CONFIG_EMPTY is used as return value as before, if no other
> > > error happens along the way.
> > > 
> > > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > > Cc: Zhigang Wang <zhigang.x.wang@xxxxxxxxxx>
> > 
> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> On second thoughts, I think this really needs an update to libxl.h to
> describe the semantics of this function, i.e. to what extent the output
> is valid for various error codes, especially ERROR_JSON_CONFIG_EMPTY.
> 

Any non-zero return code means the output is invalid (as in "Is this
output valid to rebuild a domain?").

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel