Re: [Xen-devel] [PATCH V2] Decouple SnadyBridge quirk form VTd timeout

["Dugger, Donald D" <donald.d.dugger@xxxxxxxxx>]

I'm a big believer in backward compatibility, especially in not doing things 
that change current defined behavior.  The current `snb_igd_quirk' flag enables 
the quirk code with a 1sec timeout.  Even though that value is excessive 
silently changing the meaning of the parameter just seems wrong.

--
Don Dugger
"Censeo Toto nos in Kansa esse decisse." - D. Gale
Ph: 303/443-3786

-----Original Message-----
From: Jan Beulich [mailto:JBeulich@xxxxxxxx] 
Sent: Monday, November 17, 2014 6:38 AM
To: Dugger, Donald D
Cc: Kay, Allen M; Dong, Eddie; Auld, Will; xen-devel@xxxxxxxxxxxxx
Subject: RE: [PATCH V2] Decouple SnadyBridge quirk form VTd timeout

>>> On 17.11.14 at 14:32, <donald.d.dugger@xxxxxxxxx> wrote:
> Hmm, good ideas.  How about I change the `snb_igd_quirk' parameter to be:
> 
>                 snb_igd_quirk                 => current behavior, enable 
> quirk with 1 sec timeout
>                 snb_igd_quirk=default  => enable quirk with theoretical max 
> timeout of 670 msec
>                 snb_igd_quirk=n             => enable quirk with timeout of 
> `n' msec

Please retain the current boolean behavior (i.e. =yes, =no, etc should all 
continue to be permitted). And the =yes case then would become what you propose 
above as =default. Plus I see no reason for the lack of a specified value to 
mean 1s - if 670ms is the theoretical may, there's no need to support the 1s 
one by means other than the use specifying that value on the command line.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel