Re: [Xen-devel] [PATCH] fix rename: xenstore not fully updated

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Chunyan Liu writes ("[PATCH] fix rename: xenstore not fully updated"):
> Currently libxl__domain_rename only update /local/domain/<domid>/name,
> still some places in xenstore are not updated, including:
> /vm/<uuid>/name and /local/domain/0/backend/<device>/<domid>/.../domain.

Thanks.

...
> +    /* update /vm/<uuid>/name */
> +    vm_path = libxl__xs_read(gc, trans, libxl__sprintf(gc, "%s/vm", 
> dom_path));

This seems to be obtaining the uuid from xenstore.  Can't we get it
from the hypervisor ?  That avoids quite a bit of this path fiddling.

> +    /* update backend /local/domain/0/backend/<device>/<domid>/.../domain */

Um, what on earth creates that ?

Worse, what reads it ?

I think that putting this information in the backend directory is
entirely wrong.

(Also, please use GCSPRINTF, libxl__xs_read_checked, etc., and keep
your lines to less than 75 characters or so.)

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel