[Xen-devel] [PATCH for-4.5] scripts/get_maintainer.pl: Correctly CC the maintainers

[Julien Grall <julien.grall@xxxxxxxxxx>]

By default, the script get_maintainer.pl will remove duplicates email as soon
as it appends the list of maintainers of a new file, and therefore override
the role of the developper.

On complex patch (see [1]), this will result to ommitting randomly some
maintainers.

This could be fixed by not removing the duplicate email in the list. Once the
list is created, when it's necessary, the script will drop the "REST" people
and remove duplicata.

Example:

Patch: https://patches.linaro.org/41083/

Before:

Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Ian Campbell <ian.campbell@xxxxxxxxxx>
Wei Liu <wei.liu2@xxxxxxxxxx>
George Dunlap <george.dunlap@xxxxxxxxxxxxx>
xen-devel@xxxxxxxxxxxxx

After:

Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Ian Campbell <ian.campbell@xxxxxxxxxx>
Wei Liu <wei.liu2@xxxxxxxxxx>
Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
Tim Deegan <tim@xxxxxxx>
Keir Fraser <keir@xxxxxxx>
Jan Beulich <jbeulich@xxxxxxxx>
George Dunlap <george.dunlap@xxxxxxxxxxxxx>
xen-devel@xxxxxxxxxxxxx

[1] http://lists.xenproject.org/archives/html/xen-devel/2014-11/msg00060.html

Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
CC: Don Slutz <dslutz@xxxxxxxxxxx>

---
    I would like to see this patch in Xen 4.5 and backported to Xen 4.4 (first
    time the script has been introduced).

    Developpers using this script won't ommitted to cc some maintainers, and it
    will avoid maintainers complaining about miss CC.

    The only drawbacks I can see is there is too much people CCed (the
    patch d67738db was intended to avoid CCing Keir too often).

    Also, if the maintainers is referenced twice in the file MAINTAINERS with
    different email, the script won't notice it's duplicated and list 2 times.
    Though, for this one it could be fixed by modifying  the MAINTAINERS file.
    Is it worth for Xen 4.5? For know, it seems to only happen with Stefano.
---
 scripts/get_maintainer.pl |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index df920e2..cc445cd 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -35,7 +35,7 @@ my $email_git_min_percent = 5;
 my $email_git_since = "1-year-ago";
 my $email_hg_since = "-365";
 my $interactive = 0;
-my $email_remove_duplicates = 1;
+my $email_remove_duplicates = 0;
 my $email_use_mailmap = 1;
 my $email_drop_the_rest_supporter_if_supporter_found = 1;
 my $output_multiline = 1;
-- 
1.7.10.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel