Re: [Xen-devel] [PATCH for-4.5 4/4] xen: arm: Support the other 4 PCI buses on Xgene

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 19/11/2014 09:56, Ian Campbell wrote:
> On Tue, 2014-11-18 at 17:15 +0000, Julien Grall wrote:
> > > +        default:
> > > +            /* Ignore unknown PCI busses */
> > I would add a
> > printk("Ignoring PCI busses %s\n", dt_node_full_name(dev));
> >
> > > +            ret = 0;
> > > +            break;
> > continue?
> Yes, that makes sense (probably the ret = is then unnecessary).
>
> >   You can't assume the order of the PCI busses in the device tree.
> But, I don't understand what this has to do with using continue.
The current xgene-storm DTS has the different PCI busses ordered. So as 
soon as you don't find the PCI range, it means there is no more PCI busses.
Without the continue, this patch gives the impression that you rely on 
the node order on the device tree.
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel