Re: [Xen-devel] [PATCH 2/3] x86: don't ignore foreigndom input on various MMUEXT ops

[George Dunlap <dunlapg@xxxxxxxxx>]

On Thu, Nov 20, 2014 at 10:12 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
> Instead properly fail requests that shouldn't be issued on foreign
> domains or - for MMUEXT_{CLEAR,COPY}_PAGE - extend the existing
> operation to work that way.

I take it this is for 4.6?

I've looked through it and everything looks OK.

But I agree with Tim, that having so many different changes all at the
same time makes the patch hard to review.

In particular, I'd rather start with a patch to get rid of "okay"
entirely; then make MMUEXT_{CLEAR,COPY}_PAGE use foreingndom instead
of current; then have a patch which returns -EPERM for the other ones;
then a patch to get rid of spage in MMUEXT_[UN]MARK_SUPER.

Regarding MMUEXT_{CLEAR,COPY}_PAGE: This is effectively changing the
interface.  Are we sure there are no callers which just expect them to
work on current, and don't set foreigndom properly?

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel