Re: [Xen-devel] [PATCH] set pv guest default video_memkb to 0

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-11-20 at 14:44 -0500, Konrad Rzeszutek Wilk wrote:
> On Thu, Nov 20, 2014 at 03:48:17PM +0000, Wei Liu wrote:
> > On Thu, Nov 20, 2014 at 03:29:51PM +0000, Ian Campbell wrote:
> > > On Wed, 2014-11-19 at 21:24 +0000, Wei Liu wrote:
> > > > On Wed, Nov 19, 2014 at 04:08:46PM -0500, Konrad Rzeszutek Wilk wrote:
> > > > > On Tue, Nov 18, 2014 at 03:57:08PM -0500, Zhigang Wang wrote:
> > > > > > Before this patch, pv guest video_memkb is -1, which is an invalid 
> > > > > > value.
> > > > > > And it will cause the xenstore 'memory/targe' calculation wrong:
> > > > > > 
> > > > > >     memory/target = info->target_memkb - info->video_memkb
> > > > > 
> > > > > CC-ing the maintainers.
> > > > > 
> > > > > Is this an regression as compared to Xen 4.4 or is this also in Xen 
> > > > > 4.4?
> > > > > 
> > > > 
> > > > I don't think this is a regression, it has been broken for quite a
> > > > while.
> > > 
> > > I think so to.
> > > 
> > > On the other hand its a pretty clear bug to use video_memkb == -1 and
> > > we've seen that it causes real issues. The fix is also fairly obvious.
> > > I'm inclined towards suggesting we fix this in 4.5.
> > > 
> > 
> > I concur.
> 
> Lets do it then. RElease-Acked-by: Konrad Rzeszutek Wilk 
> <konrad.wilk@xxxxxxxxxx>

APplied, thanks.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel