Re: [Xen-devel] [PATCH 2/4] sysctl/libxl: Add interface for returning IO topology data

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.12.14 at 16:55, <JBeulich@xxxxxxxx> wrote:
>>>> On 02.12.14 at 22:34, <boris.ostrovsky@xxxxxxxxxx> wrote:
>> +struct xen_sysctl_iotopo {
>> +    uint16_t seg;
>> +    uint8_t bus;
>> +    uint8_t devfn;
>> +    uint32_t node;
>> +};
> 
> This is PCI-centric without expressing in the name or layout. Perhaps
> the first part should be a union from the very beginning?

And I wonder whether that supposed union part wouldn't be nicely
done using struct physdev_pci_device.

Additionally please add IN and OUT annotations. When I first saw
this I assumed they would all be OUT (in which case the long running
loop problem mentioned in the reply to one of the other patches
wouldn't have been there), matching their CPU counterpart...

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel