Re: [Xen-devel] [PATCH v1 for-4.6 2/2] xen: prevent access to HPET from Dom0

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 19/12/14 08:04, Roger Pau Monnà wrote:
> Hello,
>
> El 18/12/14 a les 19.51, Andrew Cooper ha escrit:
>> On 18/12/14 18:27, Roger Pau Monne wrote:
>>> Prevent Dom0 from accessing HPET MMIO region by adding it to the list of
>>> denied memory regions.
>>>
>>> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
>>> Cc: Jan Beulich <jbeulich@xxxxxxxx>
>>> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> Apologies that this reply is split between patch 0 and 2 - I replied to
>> your cover letter before reading this patch.
>>
>> Denying access is only valid if acpi_table_hpet.flags & 
>> ACPI_HPET_PAGE_PROTECT4 is true.
> Thanks, if ACPI_HPET_PAGE_PROTECT4 is set then we can prevent access to
> the full page and if ACPI_HPET_PAGE_PROTECT64 is set we can prevent
> access to this page and the adjacent 60KB (15 pages). Will send an
> updated version.
>
> Roger.
>

ACPI_HPET_PAGE_PROTECT64 stems from ia64 land, where pages can be 64k. 
I believe it can safely be ignored for x86, or perhaps used to imply
ACPI_HPET_PAGE_PROTECT4

~Andrew


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel