Re: [Xen-devel] [PATCH v2 2/5] vTPM: limit libxl__add_vtpms() function to para virtual machine

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Dec 30, 2014 at 11:45:02PM -0500, Quan Xu wrote:
> Signed-off-by: Quan Xu <quan.xu@xxxxxxxxx>
> ---
>  tools/libxl/libxl_create.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> index b1ff5ae..0a09925 100644
> --- a/tools/libxl/libxl_create.c
> +++ b/tools/libxl/libxl_create.c
> @@ -1358,8 +1358,9 @@ static void domcreate_attach_vtpms(libxl__egc *egc,
>         goto error_out;
>     }
>  
> -    /* Plug vtpm devices */
> -   if (d_config->num_vtpms > 0) {
> +   /* Plug vtpm devices for para virtual domain*/
> +   if (d_config->num_vtpms > 0 &&
> +       d_config->b_info.type == LIBXL_DOMAIN_TYPE_PV) {

It's unclear to me why you stub out HVM domain. You need to state your
reasoning in comment and commit log. :-/

Wei.

>         /* Attach vtpms */
>         libxl__multidev_begin(ao, &dcs->multidev);
>         dcs->multidev.callback = domcreate_attach_pci;
> -- 
> 1.8.3.2

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel