Re: [Xen-devel] [PATCH 2/4] dt-uart: Clarify log messages at init time.

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 07/01/15 15:31, Ian Campbell wrote:
> - Don't log at all if console=dtuart (the default) was not present, in
>   that case the user has asked for something else, no need for every
>   other driver to tell them this.
> - Use "dtuart" in all other messages, rather than just "console" or
>   "uart".
> - Be more explicit if we are exiting because dtuart= wasn't given.
> - Log the options which we've parsed.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>

Regards,

> ---
>  xen/drivers/char/dt-uart.c |   11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/xen/drivers/char/dt-uart.c b/xen/drivers/char/dt-uart.c
> index 45a87a6..04dbb97 100644
> --- a/xen/drivers/char/dt-uart.c
> +++ b/xen/drivers/char/dt-uart.c
> @@ -41,9 +41,12 @@ void __init dt_uart_init(void)
>      const char *devpath = opt_dtuart;
>      char *options;
>  
> -    if ( !console_has("dtuart") || !strcmp(opt_dtuart, "") )
> +    if ( !console_has("dtuart") )
> +        return; /* Not for us */
> +
> +    if ( !strcmp(opt_dtuart, "") )
>      {
> -        printk("No console\n");
> +        printk("No dtuart path configured\n");
>          return;
>      }
>  
> @@ -53,7 +56,7 @@ void __init dt_uart_init(void)
>      else
>          options = "";
>  
> -    printk("Looking for UART console %s\n", devpath);
> +    printk("Looking for dtuart at \"%s\", options \"%s\"\n", devpath, 
> options);
>      if ( *devpath == '/' )
>          dev = dt_find_node_by_path(devpath);
>      else
> @@ -68,7 +71,7 @@ void __init dt_uart_init(void)
>      ret = device_init(dev, DEVICE_SERIAL, options);
>  
>      if ( ret )
> -        printk("Unable to initialize serial: %d\n", ret);
> +        printk("Unable to initialize dtuart: %d\n", ret);
>  }
>  
>  /*
> 


-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel