Re: [Xen-devel] [PATCH v2 4/4] dt-uart: support /chosen/stdout-path property.

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 08/01/15 11:53, Ian Campbell wrote:
> +            ret = dt_property_read_string(chosen, "stdout-path", &stdout);
> +            if ( ret >= 0 )
> +            {
> +                printk("Taking dtuart configuration from 
> /chosen/stdout-path\n");
> +                if ( strlcpy(opt_dtuart, stdout, sizeof(opt_dtuart))
> +                     >= sizeof(opt_dtuart) )
> +                    printk("WARNING: /chosen/stdout-path too long, 
> truncated\n");

I would add XENLOG_WARNING here and ...

> +            }
> +            else if ( ret != -EINVAL /* Not present */ )
> +                printk("Failed to read /chosen/stdout-path (%d)\n", ret);

XENLOG_ERROR here.

Otherwise:

Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel