Re: [Xen-devel] [PATCH v3 04/19] libxl: introduce vNUMA types

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Jan 13, 2015 at 03:40:43PM +0000, Ian Jackson wrote:
> Wei Liu writes ("[PATCH v3 04/19] libxl: introduce vNUMA types"):
> > A domain can contain several virtual NUMA nodes, hence we introduce an
> > array in libxl_domain_build_info.
> > 
> > libxl_vnode_info contains the size of memory in that node, the distance
> > from that node to every nodes, the underlying pnode and a bitmap of
> > vcpus.
> ...
> > +libxl_vnode_info = Struct("vnode_info", [
> > +    ("mem", uint64), # memory size of this node, in MiB
> > +    ("distances", Array(uint32, "num_distances")), # distances from this 
> > node to other nodes
> > +    ("pnode", uint32), # physical node of this node
> > +    ("vcpus", libxl_bitmap), # vcpus in this node
> > +    ])
> 
> Can you please document the defaults ?  It's probably tolerable to have
> that in the xl documentation (only) so maybe it should go in 19/19.
> 

There's no default values. Users have to specify every fields of this
structure at the moment, otherwise libxl refuses to proceed. I have to
check whether I actually coded that way, but that's the expected
behaviour.

I think there might be some default values when Dario finishes his work
on vNUMA auto placement. But I can't say for sure.

Wei.

> Thanks,
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel