Re: [Xen-devel] [Xen-changelog] [linux-2.6.18-xen] scsifront: avoid acquiring same lock twice if ring is full

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.01.15 at 11:36, <JGross@xxxxxxxx> wrote:
> On 01/14/2015 11:22 AM, Xen patchbot-linux-2.6.18-xen wrote:
>> @@ -463,7 +461,9 @@ static int scsifront_dev_reset_handler(s
>>              spin_unlock_irq(host->host_lock);
>>              err = wait_event_interruptible(info->wq_sync,
>>                                             !info->waiting_sync);
>> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,12)
> 
> Is this correct? I didn't check, but thought up to 2.6.12 the reset
> handler would be called with the lock already held.
> 
> In any case: either this test must be removed again or two lines above
> another test should be added for the unlock.

Indeed, I didn't look closely enough - will revert that addition.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel