Re: [Xen-devel] [Patch] static and __initdata symbols in credit2

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.01.15 at 16:11, <uma.sharma523@xxxxxxxxx> wrote:
> --- a/xen/common/sched_credit2.c
> +++ b/xen/common/sched_credit2.c
> @@ -163,7 +163,7 @@
>  #define CSFLAG_runq_migrate_request (1<<__CSFLAG_runq_migrate_request)
>  
>  
> -int opt_migrate_resist=500;
> +static int __initdata opt_migrate_resist=500;
>  integer_param("sched_credit2_migrate_resist", opt_migrate_resist);
>  
>  /*
> @@ -186,12 +186,12 @@ integer_param("sched_credit2_migrate_resist", 
> opt_migrate_resist);
>   *   to a load of 1.
>   */
>  #define LOADAVG_GRANULARITY_SHIFT (10)
> -int opt_load_window_shift=18;
> +static int __initdata opt_load_window_shift=18;
>  #define  LOADAVG_WINDOW_SHIFT_MIN 4
>  integer_param("credit2_load_window_shift", opt_load_window_shift);
> -int opt_underload_balance_tolerance=0;
> +static int __initdata opt_underload_balance_tolerance=0;
>  integer_param("credit2_balance_under", opt_underload_balance_tolerance);
> -int opt_overload_balance_tolerance=-3;
> +static int __initdata opt_overload_balance_tolerance=-3;
>  integer_param("credit2_balance_over", opt_overload_balance_tolerance);

All of them are being referenced by non-__init code, so can (and
should) become static, but not __initdata.

And while you touch these, please also add the missing blanks
around the =.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel