Re: [Xen-devel] [PATCH v2] make error codes a formal part of the ABI

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.01.15 at 17:27, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 15/01/15 15:25, Jan Beulich wrote:
>> Now that we have two cases where patches against hvmloader got
>> submitted needing to include the hypervisor's errno.h (for the host's
>> system header not necessarily reflecting the correct numbers), take
>> this as a strong sign that we need to make the error return values part
>> of the hypervisor ABI (which de-fact they've always been).
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> How do the non XEN_ prefixed E$FOO get generated with this?  All
> "#define XEN_ERRNO(...)" tokenise XEN_## onto the name.

No:

>> --- a/xen/include/xen/errno.h
>> +++ b/xen/include/xen/errno.h
>> [...]
>> +#ifndef __ASSEMBLY__
>>  
>> -#define     ENOMEDIUM       123     /* No medium found */
>> -#define     EMEDIUMTYPE     124     /* Wrong medium type */
>> +#define XEN_ERRNO(name, value) name = XEN_##name,

The XEN_## one is on the right side here ...

>> +enum {
>> +#include <public/errno.h>
>> +};
>>  
>> -/* ` } */
>> +#else /* !__ASSEMBLY__ */
>>  
>> -#endif
>> +#define XEN_ERRNO(name, value) .equ name, XEN_##name

... and here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel