Re: [Xen-devel] [PATCH] xen/many: xfree() can tolerate NULL pointers

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Jan Beulich writes ("Re: [PATCH] xen/many: xfree() can tolerate NULL pointers"):
> On 19.01.15 at 12:47, <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> > Umm, further to my last mail, we (the Free Software world in general)
> > should treat this the same way we would any other case where the
> > source code has been genuinely lost.  We start editing the output
> > file, and treat the results as the new source code.
> > 
> > (Something can only be the preferred form for modification if it
> > actually exists.)
> 
> So is this an active NAK to the patch then? Afaic the patch
> description doesn't even mention the origin being a spatch, and
> hence the change by itself seems fine to me, and consistent with
> its description - it could easily have been the result of human
> auditing of the code.

I should have been clearer.  My earlier message was a "nak until we
have the spatch too" and my most recent message was me withdrawing
that.

So I have no objection.  And this is a change I approve of, so fwiw

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

But I was also grumbling a bit about lost source code.  Next time we
could do a bit better.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel