Re: [Xen-devel] [PATCH v3 00/14] Enable vTPM subsystem on TPM 2.0

["Xu, Quan" <quan.xu@xxxxxxxxx>]

> -----Original Message-----
> From: Daniel De Graaf [mailto:dgdegra@xxxxxxxxxxxxx]
> Sent: Tuesday, January 13, 2015 11:54 PM
> To: Xu, Quan; xen-devel@xxxxxxxxxxxxx
> Cc: stefano.stabellini@xxxxxxxxxxxxx; samuel.thibault@xxxxxxxxxxxx;
> ian.campbell@xxxxxxxxxx; ian.jackson@xxxxxxxxxxxxx; jbeulich@xxxxxxxx;
> keir@xxxxxxx; tim@xxxxxxx
> Subject: Re: [PATCH v3 00/14] Enable vTPM subsystem on TPM 2.0
> 
> On 01/12/2015 11:06 AM, Xu, Quan wrote:
> > Graaf,
> > Now there are no more comments for this series of patch.
> > Can this series of patch be merged in staging branch? or any other AR, let 
> > me
> know.
> > If the series of patch are in staging branch, the Community and I can 
> > continue
> to develop and enhance it.
> 
> A few remaining comments:
> 
> Patch 6 adds an #if 0 block; is this test code that you meant to remove?
> 
> Patch 9 (see reply).
> 
> Are you planning to replace TPM2_Bind with TPM2_Seal in a later series?
> If so, please make a note of this limitation in the documentation for TPM2, 
> since
> using PCRs to seal the data can be an important security feature that users 
> of the
> vtpmmgr rely on.
> 
> For the other patches in this series (1-5,7-8,10):
> Acked-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
> 
> With patch #14 documenting the lack of TPM2 sealing, #11-13 are also Acked.
> 
> - Daniel
> 


Thanks for your review.
I have sent out v4 based on your remaining comments. Could you help me check it 
again? Thanks.
The subject is "[PATCH v4 00/14] Enable vTPM subsystem on TPM 2.0"

-Quan

> 
> --
> Daniel De Graaf
> National Security Agency
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel